netdev - Re: [PATCH next 5/6] bonding: Allow userspace to set macaddr on bonding-dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150207142652.708bd66e@urahara>
Date:	Sat, 7 Feb 2015 14:26:52 -0800
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Mahesh Bandewar <maheshb@...gle.com>
Cc:	Jay Vosburgh <j.vosburgh@...il.com>,
	Andy Gospodarek <andy@...yhouse.net>,
	Veaceslav Falico <vfalico@...il.com>,
	Nikolay Aleksandrov <nikolay@...hat.com>,
	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH next 5/6] bonding: Allow userspace to set macaddr on
 bonding-dev

On Fri,  6 Feb 2015 16:51:56 -0800
Mahesh Bandewar <maheshb@...gle.com> wrote:

> @@ -396,6 +398,13 @@ static const struct bond_option bond_opts[BOND_OPT_LAST] = {
>  		.values = bond_ad_actor_sysprio_tbl,
>  		.set = bond_option_ad_actor_sysprio_set,
>  	},
> +	[BOND_OPT_AD_ACTOR_SYS_MACADDR] = {
> +		.id = BOND_OPT_AD_ACTOR_SYS_MACADDR,
> +		.name = "ad_actor_system_mac_address",
> +		.unsuppmodes = BOND_MODE_ALL_EX(BIT(BOND_MODE_8023AD)),
> +		.flags = BOND_OPTFLAG_RAWVAL | BOND_OPTFLAG_IFDOWN,
> +		.set = bond_option_ad_actor_sys_macaddr_set,
> +	},
>  };

I would consider the module command line options deprecated
at this point. Why add more?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html