netdev - Re: [GIT] Networking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFzJNNDi0YKXnNYF=ccYvXALRxzngiV1tARd6CdCimVRYg@mail.gmail.com>
Date:	Tue, 10 Feb 2015 13:26:06 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	David Miller <davem@...emloft.net>
Cc:	Al Viro <viro@...iv.linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Network Development <netdev@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT] Networking

On Tue, Feb 10, 2015 at 8:58 AM, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
> On Tue, Feb 10, 2015 at 8:33 AM, Linus Torvalds
> <torvalds@...ux-foundation.org> wrote:
>>
>> Will try your suggestion,
>
> Nope, that wasn't it. It still hangs in the same place (I forgot to
> get rid of the red hat graphical boot screen so I didn't see the oops,
> but ..)

Just to confirm that yes, it's that particular commit 1d10eb2f156f.

I reverted it and things work again. So it's not the miscalculation of
"used" , but it's certainly *something* in that commit.

Oh well. I have a ton of other trees to pull, so I'll just drop this for now.

> Looking more closely at the generated code, and the fact that the oops
> was an access at offset 0x18 from a NULL pointer, it would *look* like
> it's this instruction:
>
>         call    *24(%rax)       # MEM[(struct ablkcipher_tfm *)_48 + 8B].decrypt

Double-checked, and yes, "skcipher_recvmsg+0x360/0x410" is that call
to the decrypt routine.

So it looks like for some reason that

    struct ablkcipher_tfm *crt =
        crypto_ablkcipher_crt(crypto_ablkcipher_reqtfm(req));;

ends up being NULL in

     crypto_ablkcipher_decrypt(&ctx->req)

causing the oops.  I just don't see what the heck in that patch would
have changed any of that.

                        Linus
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html