netdev - Re: [GIT] Networking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFyqFrf9cRQ7wDSDLNraR+meZ-=dwWdDThtpPtrFFqrcGw@mail.gmail.com>
Date:	Tue, 10 Feb 2015 13:50:16 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	David Miller <davem@...emloft.net>
Cc:	Al Viro <viro@...iv.linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Network Development <netdev@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT] Networking

On Tue, Feb 10, 2015 at 1:26 PM, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
> Just to confirm that yes, it's that particular commit 1d10eb2f156f.
>
> I reverted it and things work again. So it's not the miscalculation of
> "used" , but it's certainly *something* in that commit.

How about this?

-       npages = (off + len + PAGE_SIZE - 1) >> PAGE_SHIFT;
+       npages = PAGE_ALIGN(off + n);

The two are not even *remotely* the same thing.

It's in af_alg_make_sg(), and it would seem to cause sg_init_table()
and the loop that does sg_set_page() do insane things. Possibly
including random memory scribbles etc. Which could explain anything.

Anyway, I'm now working on the other pulls I have, so I'll leave this
for now, but I think that might be it.

                         Linus
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html