netdev - Re: [PATCH net] openvswitch: Reset key metadata for packet execution.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150211.144056.991311291193384410.davem@davemloft.net>
Date:	Wed, 11 Feb 2015 14:40:56 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	pshelar@...ira.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] openvswitch: Reset key metadata for packet
 execution.

From: Pravin B Shelar <pshelar@...ira.com>
Date: Tue, 10 Feb 2015 13:35:16 -0800

> Userspace packet execute command pass down flow key for given
> packet. But userspace can skip some parameter with zero value.
> Therefore kernel needs to initialize key metadata to zero.
> 
> Fixes: 0714812134 ("openvswitch: Eliminate memset() from flow_extract.")
> Signed-off-by: Pravin B Shelar <pshelar@...ira.com>

Applied, but...

> + 	memset(key, 0, OVS_SW_FLOW_KEY_METADATA_SIZE);

There's a space before the TAB in that indentation, and git even
warns about this when applying patches.

I fixed it up, but this is one of the basic things you should be
dealing with before submitting your changes.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html