netdev - Re: [PATCH] openvswitch: Add missing initialization in validate_and_copy_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150211.144105.402784068369724984.davem@davemloft.net>
Date:	Wed, 11 Feb 2015 14:41:05 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	geert@...ux-m68k.org
Cc:	pshelar@...ira.com, tgraf@...g.ch, netdev@...r.kernel.org,
	dev@...nvswitch.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] openvswitch: Add missing initialization in
 validate_and_copy_set_tun()

From: Geert Uytterhoeven <geert@...ux-m68k.org>
Date: Wed, 11 Feb 2015 11:23:38 +0100

> net/openvswitch/flow_netlink.c: In function ‘validate_and_copy_set_tun’:
> net/openvswitch/flow_netlink.c:1749: warning: ‘err’ may be used uninitialized in this function
> 
> If ipv4_tun_from_nlattr() returns a different positive value than
> OVS_TUNNEL_KEY_ATTR_GENEVE_OPTS, err will be uninitialized, and
> validate_and_copy_set_tun() may return an undefined value instead of a
> zero success indicator. Initialize err to zero to fix this.
> 
> Fixes: 1dd144cf5b4b47e1 ("openvswitch: Support VXLAN Group Policy extension")
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Applied.