netdev - Re: [RFC PATCH net-next] ipv6: fix ipv6_cow_metrics for non DST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1423776759.3051.5.camel@stressinduktion.org>
Date:	Thu, 12 Feb 2015 16:32:39 -0500
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	Martin KaFai Lau <kafai@...com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	Kernel Team <kernel-team@...com>
Subject: Re: [RFC PATCH net-next] ipv6: fix ipv6_cow_metrics for non
 DST_HOST case

Hi,

On Do, 2015-02-12 at 12:07 -0800, Martin KaFai Lau wrote:
> ipv6_cow_metrics() currently assumes only DST_HOST routes require
> dynamic metrics allocation from inetpeer.  The assumption breaks
> when ndisc discovered router with RTAX_MTU and RTAX_HOPLIMIT metric.
> Refer to ndisc_router_discovery() in ndisc.c and note that dst_metric_set()
> is called after the route is created.
> 
> This patch creates the metrics array (by calling dst_cow_metrics_generic) in
> ipv6_cow_metrics().
> 
> Test:
> radvd.conf:
> interface qemubr0
> {
> 	AdvLinkMTU 1300;
> 	AdvCurHopLimit 30;
> 
> 	prefix fd00:face:face:face::/64
> 	{
> 		AdvOnLink on;
> 		AdvAutonomous on;
> 		AdvRouterAddr off;
> 	};
> };
> 
> Before:
> [root@...u1 ~]# ip -6 r show | egrep -v unreachable
> fd00:face:face:face::/64 dev eth0  proto kernel  metric 256  expires 27sec
> fe80::/64 dev eth0  proto kernel  metric 256
> default via fe80::74df:d0ff:fe23:8ef2 dev eth0  proto ra  metric 1024  expires 27sec
> 
> After:
> [root@...u1 ~]# ip -6 r show | egrep -v unreachable
> fd00:face:face:face::/64 dev eth0  proto kernel  metric 256  expires 27sec mtu 1300
> fe80::/64 dev eth0  proto kernel  metric 256  mtu 1300
> default via fe80::74df:d0ff:fe23:8ef2 dev eth0  proto ra  metric 1024  expires 27sec mtu 1300 hoplimit 30
> 
> Signed-off-by: Martin KaFai Lau <kafai@...com>

Looks good to me.

This fixes 8e2ec639173f325 ("ipv6: don't use inetpeer to store metrics
for routes.")?

Thanks,
Hannes


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html