netdev - Re: [PATCH net] tcp: make sure skb is not shared before using skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150213.071213.1105639128565896413.davem@davemloft.net>
Date:	Fri, 13 Feb 2015 07:12:13 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, ycheng@...gle.com
Subject: Re: [PATCH net] tcp: make sure skb is not shared before using
 skb_get()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 13 Feb 2015 04:47:12 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> IPv6 can keep a copy of SYN message using skb_get() in
> tcp_v6_conn_request() so that caller wont free the skb when calling
> kfree_skb() later.
>     
> Therefore TCP fast open has to clone the skb it is queuing in
> child->sk_receive_queue, as all skbs consumed from receive_queue are
> freed using __kfree_skb() (ie assuming skb->users == 1)
>     
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Yuchung Cheng <ycheng@...gle.com>
> Fixes: 5b7ed0892f2af ("tcp: move fastopen functions to tcp_fastopen.c")

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html