netdev - Re: [PATCH] hso: fix rx parsing logic when skb allocation fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 13 Feb 2015 07:17:29 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	aleksander@...ksander.es
Cc:	linux-usb@...r.kernel.org, netdev@...r.kernel.org,
	j.dumon@...ion.com
Subject: Re: [PATCH] hso: fix rx parsing logic when skb allocation fails

From: Aleksander Morgado <aleksander@...ksander.es>
Date: Fri, 13 Feb 2015 14:51:02 +0100

> If skb allocation fails once the IP header has been received, the rx state is
> being set to WAIT_SYNC. The logic, though, shouldn't directly return, as the
> buffer may contain a full packet, and therefore the WAIT_SYNC state needs to be
> processed (resetting state to WAIT_IP, clearing rx_buf_size and re-initializing
> rx_buf_missing).
> 
> So, just let the while loop continue so that in the next iteration the WAIT_SYNC
> state cleanly stops the loop. The WAIT_SYNC processing will be done just after
> that, only if the end of packet is flagged.
> 
> Signed-off-by: Aleksander Morgado <aleksander@...ksander.es>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html