netdev - Re: [PATCH] net: Remove state argument from skb_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150219000559.GA28854@salvia>
Date:	Thu, 19 Feb 2015 01:05:59 +0100
From:	Pablo Neira Ayuso <pablo@...filter.org>
To:	Bojan Prtvar <prtvar.b@...il.com>
Cc:	netdev@...r.kernel.org, tgraf@...g.ch,
	netfilter-devel@...r.kernel.org, netfilter@...r.kernel.org,
	dan.carpenter@...cle.com
Subject: Re: [PATCH] net: Remove state argument from skb_find_text()

On Thu, Feb 19, 2015 at 12:16:48AM +0100, Bojan Prtvar wrote:
> Although it is clear that textsearch state is intentionally passed
> to skb_find_text() as uninitialized argument, it was never used by
> the callers. Therefore, we can simplify skb_find_text() by making it
> local variable.

This infrastructure was conceived to allow keeping the state between
chunk of data, I don't find a good reason to restrict this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html