netdev - Re: [PATCH] net: Remove state argument from skb_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150220.172233.1250644959779215916.davem@davemloft.net>
Date:	Fri, 20 Feb 2015 17:22:33 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	prtvar.b@...il.com
Cc:	netdev@...r.kernel.org, tgraf@...g.ch,
	netfilter-devel@...r.kernel.org, netfilter@...r.kernel.org,
	dan.carpenter@...cle.com
Subject: Re: [PATCH] net: Remove state argument from skb_find_text()

From: Bojan Prtvar <prtvar.b@...il.com>
Date: Thu, 19 Feb 2015 00:16:48 +0100

> Although it is clear that textsearch state is intentionally passed
> to skb_find_text() as uninitialized argument, it was never used by
> the callers. Therefore, we can simplify skb_find_text() by making it
> local variable.
> 
> Signed-off-by: Bojan Prtvar <prtvar.b@...il.com>

Although I partially agree with Pablo's response these interfaces were
designed to be able to hold state across calls, nobody uses them this
way yet.  So this change is fine and we can resurrect the argument
if a use appears in the future.

However, your patch doesn't apply cleanly, please respin.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html