netdev - Re: [PATCH net-next v5] Add support of Cavium Liquidio ethernet adapters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150219.143610.1038570471548445608.davem@davemloft.net>
Date:	Thu, 19 Feb 2015 14:36:10 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	rvatsavayi@...iumnetworks.com
Cc:	netdev@...r.kernel.org, derek.chickles@...iumnetworks.com,
	satananda.burla@...iumnetworks.com,
	felix.manlunas@...iumnetworks.com,
	raghu.vatsavayi@...iumnetworks.com
Subject: Re: [PATCH net-next v5] Add support of Cavium Liquidio ethernet
 adapters

From: Raghu Vatsavayi <rvatsavayi@...iumnetworks.com>
Date: Wed, 11 Feb 2015 17:20:42 -0800

> +	uint32_t val;

uint32_t, uint64_t, etc. are userspace types, and inside the kernel
one should canonically use u32, u64, etc.

Please update your entire driver wrt. this issue.

> +	pci_unmap_single(lio->oct_dev->pci_dev, finfo->dptr, skb->len,
> +			 PCI_DMA_TODEVICE);

Please use the dma_*() variants of the DMA interfaces for which you
will pass in a reference to the struct device embedded in the pci_dev.

This will allow you to later make use of various generic facilities
we will build for DMA mapping SKBs in the networking, allocating
networknig page frags, etc.

And even more importantly, the pci_*() variants are slowly being
phased out and deprecated.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html