netdev - RE: [PATCH net-next v5] Add support of Cavium Liquidio ethernet adapters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY2PR07MB486BB911FB76C60D322131AFE2D0@BY2PR07MB486.namprd07.prod.outlook.com>
Date:	Thu, 19 Feb 2015 20:44:11 +0000
From:	"Chickles, Derek" <Derek.Chickles@...iumnetworks.com>
To:	David Miller <davem@...emloft.net>,
	"Vatsavayi, Raghu" <Raghu.Vatsavayi@...iumnetworks.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Burla, Satananda" <Satananda.Burla@...iumnetworks.com>,
	"Manlunas, Felix" <Felix.Manlunas@...iumnetworks.com>,
	"Vatsavayi, Raghu" <Raghu.Vatsavayi@...iumnetworks.com>
Subject: RE: [PATCH net-next v5] Add support of Cavium Liquidio ethernet
 adapters

> From: David Miller [mailto:davem@...emloft.net]
> Sent: Thursday, February 19, 2015 11:36 AM
> To: Vatsavayi, Raghu
> Cc: netdev@...r.kernel.org; Chickles, Derek; Burla, Satananda; Manlunas,
> Felix; Vatsavayi, Raghu
> Subject: Re: [PATCH net-next v5] Add support of Cavium Liquidio ethernet
> adapters
> 
> From: Raghu Vatsavayi <rvatsavayi@...iumnetworks.com>
> Date: Wed, 11 Feb 2015 17:20:42 -0800
> 
> > +	pci_unmap_single(lio->oct_dev->pci_dev, finfo->dptr, skb->len,
> > +			 PCI_DMA_TODEVICE);
> 
> Please use the dma_*() variants of the DMA interfaces for which you
> will pass in a reference to the struct device embedded in the pci_dev.
> 
> This will allow you to later make use of various generic facilities
> we will build for DMA mapping SKBs in the networking, allocating
> networknig page frags, etc.
> 

You said you *will* be building these facilities. Are there any now
that we can take advantage of? (We'll move to the dma_* variants
regardless.)

Also, do you have any remaining style / global comments that we should
address?

Thanks,
Derek
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html