[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20150219.151938.2124980198109409450.davem@davemloft.net>
Date: Thu, 19 Feb 2015 15:19:38 -0500 (EST)
From: David Miller <davem@...emloft.net>
To: tobias@...dekranz.com
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] dsa: mv88e6131: support fixed PHYs
From: Tobias Waldekranz <tobias@...dekranz.com>
Date: Thu, 12 Feb 2015 15:13:17 +0100
> Statically setup the PCS Control on the MAC to match the fixed PHY.
>
> Signed-off-by: Tobias Waldekranz <tobias@...dekranz.com>
...
> + /* PPU will configure MACs with physical PHYs */
> + if (!fixed_phy_get_status(phy))
> + return;
I kind of agree with Florian that you probably don't need this.
And furthermore, this fixed_phy_get_status() interface you created
isn't even used for what it's designed for.
As coded, fixed_phy_get_status() returns the link status structure,
but here you are only interested in whether a phy is fixed or not
because you're simply making a boolean test upon whether you were
given a non-NULL fixed phy status or not.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists