lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20150221103005.GA9212@gmail.com> Date: Sat, 21 Feb 2015 11:30:05 +0100 From: Tobias Waldekranz <tobias@...dekranz.com> To: Florian Fainelli <f.fainelli@...il.com> Cc: netdev <netdev@...r.kernel.org> Subject: Re: [PATCH 2/2] dsa: mv88e6131: support fixed PHYs On Thu, Feb 12, 2015 at 08:13:28AM -0800, Florian Fainelli wrote: > 2015-02-12 6:13 GMT-08:00 Tobias Waldekranz <tobias@...dekranz.com>: > > Statically setup the PCS Control on the MAC to match the fixed PHY. > > bcm_sf2 supports both fixed PHYs and regular PHYs, yet we do not need > to get access to the fixed PHY status from the adjust_link callback > because you could implement a separate fixed_link_update callback for > that purpose. > > Did not that work for you? > That was my first approach and it worked fine. The only issue I saw was that the callback was continously called at each poll cycle even though the link state had not changed. So then I implemented the same check for updates that was in the regular adjust_link callback. But before I submitted that version of the patch I looked att the sf2 code, and it seemed as though this code uses the callback to update the phy status based on the chip state and not the other way around. Did I misunderstand the code? Not wanting to break your code, I went with this approach instead. But if you're fine with it, I'm more than happy to go with that version. -- Thanks - wkz -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists