netdev - Re: Altera TSE (altera_tse) - tx_fifo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150220.151722.167446633406590850.davem@davemloft.net>
Date:	Fri, 20 Feb 2015 15:17:22 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	setka@...s.cz
Cc:	netdev@...r.kernel.org, vbridger@...nsource.altera.com
Subject: Re: Altera TSE (altera_tse) - tx_fifo_depth init bug

From: Vlastimil Setka <setka@...s.cz>
Date: Mon, 16 Feb 2015 23:43:15 +0100

>> Your patch was corrupted by your email client, in particular TAB
>> characters were transformed into a series of SPACE characters.
> 
> Hello,
> sorry for inconvenience, here is a correct patch:

This is not the correct way to submit a patch.

You should never provide a patch for us to apply as a reply to another
email.

Instead you should always make a fresh, new, mailing list posting.

Your Subject line and message body should contain only the exact
text you want to appear in the commit message.  You should not
include things like "Hello, " or other trivialities that would
need to be edited out.

Also, your Subject line should be of the form:

	$subsystem: $description

Where subsystem is the most specific name of the area you're
changing, in lowercase letters.

You should not use multi-word sequences as you have to state
the subsystem.  Simply "altera_tse: " is completely sufficient.

The most annoying thing about seeing the errors you are making is that
if you simply mimicked at how other driver maintainers arrange their
subject lines and message bodies, you would end up doing the right
thing.

Use what other people do as a guide, and don't try to do things in
a special or unique way.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html