netdev - Re: [PATCH net] rhashtable: don't allocate ht structure on stack in test_rht

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150220201619.GF4586@casper.infradead.org>
Date:	Fri, 20 Feb 2015 20:16:19 +0000
From:	Thomas Graf <tgraf@...g.ch>
To:	Daniel Borkmann <daniel@...earbox.net>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net] rhashtable: don't allocate ht structure on stack in
 test_rht_init

On 02/20/15 at 09:14pm, Daniel Borkmann wrote:
> With object runtime debugging enabled, the rhashtable test suite
> will rightfully throw a warning "ODEBUG: object is on stack, but
> not annotated" from rhashtable_init().
> 
> This is because run_work is (correctly) being initialized via
> INIT_WORK(), and not annotated by INIT_WORK_ONSTACK(). Meaning,
> rhashtable_init() is okay as is, we just need to move ht e.g.,
> into global scope.
> 
> It never triggered anything, since test_rhashtable is rather a
> controlled environment and effectively runs to completion, so
> that stack memory is not vanishing underneath us, we shouldn't
> confuse any testers with it though.
> 
> Fixes: 7e1e77636e36 ("lib: Resizable, Scalable, Concurrent Hash Table")
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>

Thanks for looking into this.

Acked-by: Thomas Graf <tgraf@...g.ch>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html