netdev - Re: [PATCH net-next RFC 5/5] rocker: explicitly set SW ageing for rocker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150220092518.GA2008@nanopsycho.orion>
Date:	Fri, 20 Feb 2015 10:46:06 +0100
From:	Jiri Pirko <jiri@...nulli.us>
To:	sfeldma@...il.com
Cc:	netdev@...r.kernel.org, roopa@...ulusnetworks.com,
	linux@...ck-us.net, f.fainelli@...il.com, andrew@...n.ch,
	gospo@...ulusnetworks.com, vbandaru@...adcom.com,
	siva.mannem.lnx@...il.com
Subject: Re: [PATCH net-next RFC 5/5] rocker: explicitly set SW ageing for
 rocker

Fri, Feb 20, 2015 at 08:09:55AM CET, sfeldma@...il.com wrote:
>From: Scott Feldman <sfeldma@...il.com>
>
>Rocker (for now) will rely on SW (bridge) ageing.  Other drivers/devices may
>wish to set NTF_EXT_AGED to turn off SW (bridge) ageing.
>
>Signed-off-by: Scott Feldman <sfeldma@...il.com>
>---
> drivers/net/ethernet/rocker/rocker.c |    9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/net/ethernet/rocker/rocker.c b/drivers/net/ethernet/rocker/rocker.c
>index 34389b6a..7b55934 100644
>--- a/drivers/net/ethernet/rocker/rocker.c
>+++ b/drivers/net/ethernet/rocker/rocker.c
>@@ -3026,10 +3026,11 @@ static void rocker_port_fdb_learn_work(struct work_struct *work)
> 		container_of(work, struct rocker_fdb_learn_work, work);
> 	bool removing = (lw->flags & ROCKER_OP_FLAG_REMOVE);
> 	bool learned = (lw->flags & ROCKER_OP_FLAG_LEARNED);
>-	struct netdev_switch_notifier_fdb_info info;
>-
>-	info.addr = lw->addr;
>-	info.vid = lw->vid;
>+	struct netdev_switch_notifier_fdb_info info = {
>+		.addr = lw->addr,
>+		.vid = lw->vid,
>+		.ntf_flags = NTF_EXT_LEARNED,
>+	};

I think that this patch should be before "bridge: call external learn add
if adding FDB entry with NTF_EXT_LEARNED set" in order to not break
functionality during bisect.

> 
> 	if (learned && removing)
> 		call_netdev_switch_notifiers(NETDEV_SWITCH_FDB_DEL,
>-- 
>1.7.10.4
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html