lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAE4R7bAgjO6z4Fp56Yass==FPBR3viCMUXdk1E9FxG3dOaHXzg@mail.gmail.com> Date: Fri, 20 Feb 2015 06:56:53 -0800 From: Scott Feldman <sfeldma@...il.com> To: Jiri Pirko <jiri@...nulli.us> Cc: Netdev <netdev@...r.kernel.org>, Roopa Prabhu <roopa@...ulusnetworks.com>, Guenter Roeck <linux@...ck-us.net>, Florian Fainelli <f.fainelli@...il.com>, andrew@...n.ch, Andy Gospodarek <gospo@...ulusnetworks.com>, vbandaru@...adcom.com, Siva Mannem <siva.mannem.lnx@...il.com> Subject: Re: [PATCH net-next RFC 5/5] rocker: explicitly set SW ageing for rocker On Fri, Feb 20, 2015 at 1:46 AM, Jiri Pirko <jiri@...nulli.us> wrote: > Fri, Feb 20, 2015 at 08:09:55AM CET, sfeldma@...il.com wrote: >>From: Scott Feldman <sfeldma@...il.com> >> >>Rocker (for now) will rely on SW (bridge) ageing. Other drivers/devices may >>wish to set NTF_EXT_AGED to turn off SW (bridge) ageing. >> >>Signed-off-by: Scott Feldman <sfeldma@...il.com> >>--- >> drivers/net/ethernet/rocker/rocker.c | 9 +++++---- >> 1 file changed, 5 insertions(+), 4 deletions(-) >> >>diff --git a/drivers/net/ethernet/rocker/rocker.c b/drivers/net/ethernet/rocker/rocker.c >>index 34389b6a..7b55934 100644 >>--- a/drivers/net/ethernet/rocker/rocker.c >>+++ b/drivers/net/ethernet/rocker/rocker.c >>@@ -3026,10 +3026,11 @@ static void rocker_port_fdb_learn_work(struct work_struct *work) >> container_of(work, struct rocker_fdb_learn_work, work); >> bool removing = (lw->flags & ROCKER_OP_FLAG_REMOVE); >> bool learned = (lw->flags & ROCKER_OP_FLAG_LEARNED); >>- struct netdev_switch_notifier_fdb_info info; >>- >>- info.addr = lw->addr; >>- info.vid = lw->vid; >>+ struct netdev_switch_notifier_fdb_info info = { >>+ .addr = lw->addr, >>+ .vid = lw->vid, >>+ .ntf_flags = NTF_EXT_LEARNED, >>+ }; > > I think that this patch should be before "bridge: call external learn add > if adding FDB entry with NTF_EXT_LEARNED set" in order to not break > functionality during bisect. Ok, I reordered 'em. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists