netdev - Re: [PATCH net 2/3] rhashtable: better high order allocation attempts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1424439975.5565.0.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Fri, 20 Feb 2015 05:46:15 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Laight <David.Laight@...LAB.COM>
Cc:	'Daniel Borkmann' <daniel@...earbox.net>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"tgraf@...g.ch" <tgraf@...g.ch>,
	"johunt@...mai.com" <johunt@...mai.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net 2/3] rhashtable: better high order allocation
 attempts

On Fri, 2015-02-20 at 10:11 +0000, David Laight wrote:
> From: Daniel Borkmann
> > When trying to allocate future tables via bucket_table_alloc(), it seems
> > overkill on large table shifts that we probe for kzalloc() unconditionally
> > first, as it's likely to fail.
> 
> How about a two-level array for large tables?
> Then you don't need to allocate more than 1 page at a time?

This is called vmalloc() in linux kernel.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html