lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <54E73BE4.2040505@solarflare.com> Date: Fri, 20 Feb 2015 13:51:32 +0000 From: Edward Cree <ecree@...arflare.com> To: Hiroshi Shimamoto <h-shimamoto@...jp.nec.com> CC: "Skidmore, Donald C" <donald.c.skidmore@...el.com>, "vyasevic@...hat.com" <vyasevic@...hat.com>, "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>, Alexander Duyck <alexander.duyck@...il.com>, Bjørn Mork <bjorn@...k.no>, "e1000-devel@...ts.sourceforge.net" <e1000-devel@...ts.sourceforge.net>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Choi, Sy Jong" <sy.jong.choi@...el.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, David Laight <David.Laight@...LAB.COM>, Hayato Momma <h-momma@...jp.nec.com> Subject: Re: [PATCH v2 2/3] if_link: Add VF multicast promiscuous control On 20/02/15 01:00, Hiroshi Shimamoto wrote: > From: Hiroshi Shimamoto <h-shimamoto@...jp.nec.com> > > Add netlink directives and ndo entry to allow VF multicast promiscuous mode. > > The administrator wants to allow dedicatedly multicast promiscuous per VF. If I'm properly understanding, this seems to be an ixgbe-specific option to work around an ixgbe limitation; is it really appropriate to implement as a generic net_device_op? What would this ndo mean to a driver which can support thousands of multicast groups without MC promisc? Is it expected to limit the number of MC groups when this is set to disallow? Or just fulfil the letter of the option but not its spirit? The option doesn't seem to have well-defined semantics outside of ixgbe. I would suggest that the right place for this sort of driver-specific device control is in sysfs. I'm also a little perplexed as to why anyone would need to disallow this; what security, or even administrative convenience, is gained by allowing a VF to join 30 multicast groups but not multicast promiscuous mode? Especially as, afaik, there are no restrictions on which multicast groups are joined, so the VF can receive any particular multicast traffic it cares about. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists