netdev - Re: [PATCH net-next] bridge: add vlan info to bridge setlink and dellink notification messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150222.230200.417142094091853578.davem@davemloft.net>
Date:	Sun, 22 Feb 2015 23:02:00 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	roopa@...ulusnetworks.com
Cc:	netdev@...r.kernel.org, stephen@...workplumber.org,
	vyasevic@...hat.com, sfeldma@...il.com, wkok@...ulusnetworks.com,
	siva.mannem.lnx@...il.com
Subject: Re: [PATCH net-next] bridge: add vlan info to bridge setlink and
 dellink notification messages

From: roopa@...ulusnetworks.com
Date: Sat, 21 Feb 2015 20:21:51 -0800

> From: Roopa Prabhu <roopa@...ulusnetworks.com>
> 
> vlan add/deletes are not notified to userspace today. This patch adds
> vlan info to bridge newlink/dellink notifications generated from the bridge
> driver. Notifications use the RTEXT_FILTER_BRVLAN_COMPRESSED flag to compress vlans into ranges whereever applicable.

Please format your commit message text to ~80 columns in the
future, thanks.

> The size calculations does not take ranges into account for simplicity.
> This has the potential for allocating a larger skb than required.
> 
> There is an existing inconsistency with bridge NEWLINK and
> DELLINK change notifications. Both generate NEWLINK notifications.
> Since its always a NEWLINK notification, this patch includes all
> vlans the port belongs to in the notification. The NEWLINK and DELLINK
> request messages however only include the vlans to be added and
> deleted.
> 
> Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com>

This looks fine to me, applied.

If you would put at least some time into trying to reduce the
allocation size, taking range compression into consideration,
I'd very much appreciate it as a follow-on patch.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html