netdev - Re: [PATCH net-next] tcp: fix tcp_should_expand_sndbuf() to use tcp_packets_in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150222.230731.1964374887839422637.davem@davemloft.net>
Date:	Sun, 22 Feb 2015 23:07:31 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ncardwell@...gle.com
Cc:	netdev@...r.kernel.org, ycheng@...gle.com, edumazet@...gle.com,
	nanditad@...gle.com
Subject: Re: [PATCH net-next] tcp: fix tcp_should_expand_sndbuf() to use
 tcp_packets_in_flight()

From: Neal Cardwell <ncardwell@...gle.com>
Date: Fri, 20 Feb 2015 13:33:16 -0500

> tcp_should_expand_sndbuf() does not expand the send buffer if we have
> filled the congestion window.
> 
> However, it should use tcp_packets_in_flight() instead of
> tp->packets_out to make this check.
> 
> Testing has established that the difference matters a lot if there are
> many SACKed packets, causing a needless performance shortfall.
> 
> Signed-off-by: Neal Cardwell <ncardwell@...gle.com>
> Signed-off-by: Yuchung Cheng <ycheng@...gle.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Nandita Dukkipati <nanditad@...gle.com>

This is a bug in my view, thus applying to 'net'.

Thanks Neal.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html