netdev - Re: [PATCH net-next] i40e: mark constant as ULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54EC69B9.6020904@kpanic.de>
Date:	Tue, 24 Feb 2015 13:08:25 +0100
From:	Stefan Assmann <sassmann@...nic.de>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
CC:	netdev@...r.kernel.org, davem@...emloft.net,
	e1000-devel@...ts.sourceforge.net
Subject: Re: [PATCH net-next] i40e: mark constant as ULL

On 23.02.2015 15:56, Stefan Assmann wrote:
> On 04.02.2015 18:49, Jeff Kirsher wrote:
>> On Wed, 2015-02-04 at 12:41 +0100, Stefan Assmann wrote:
>>> This avoids a compile error on 32bit.
>>>
>>> Signed-off-by: Stefan Assmann <sassmann@...nic.de>
>>> ---
>>>  drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Come to find out, I already have a fix in my queue for this.  So I will
>> be dropping your patch.
>>
>> The patch in my queue fixes the issue by doing the folling change:
>> -               mask = 0xFFFFFFFFFFFFFFFF;
>> +               mask = ~(u64)0;
>>
> 
> Jeff,
> 
> this does not seem to compile on 32bit either. Please verify and if
> you agree let's put my patch back in place instead of this one. IIRC
> your patch has not been posted yet.
> 
>   Stefan
> 

Jeff,

I fat fingered this, everything ok. Please ignore my last comment.

  Stefan
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html