netdev - Re: [PATCH net-next] i40e: mark constant as ULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1424780625.2553.10.camel@jtkirshe-mobl>
Date:	Tue, 24 Feb 2015 04:23:45 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Stefan Assmann <sassmann@...nic.de>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	e1000-devel@...ts.sourceforge.net
Subject: Re: [PATCH net-next] i40e: mark constant as ULL

On Tue, 2015-02-24 at 13:08 +0100, Stefan Assmann wrote:
> On 23.02.2015 15:56, Stefan Assmann wrote:
> > On 04.02.2015 18:49, Jeff Kirsher wrote:
> >> On Wed, 2015-02-04 at 12:41 +0100, Stefan Assmann wrote:
> >>> This avoids a compile error on 32bit.
> >>>
> >>> Signed-off-by: Stefan Assmann <sassmann@...nic.de>
> >>> ---
> >>>  drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> Come to find out, I already have a fix in my queue for this.  So I
> will
> >> be dropping your patch.
> >>
> >> The patch in my queue fixes the issue by doing the folling change:
> >> -               mask = 0xFFFFFFFFFFFFFFFF;
> >> +               mask = ~(u64)0;
> >>
> > 
> > Jeff,
> > 
> > this does not seem to compile on 32bit either. Please verify and if
> > you agree let's put my patch back in place instead of this one. IIRC
> > your patch has not been posted yet.
> > 
> >   Stefan
> > 
> 
> Jeff,
> 
> I fat fingered this, everything ok. Please ignore my last comment.

Ok, good to know.  I was wondering why our validation had not seen the
same issue.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)