netdev - Re: [PATCH net-next 1/7] net: bluetooth: compact struct bt_skb_cb by inlining struct hci_req

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHsH6GtrrJTTo58ih3xV5-+W8fe08u_70ZVXzZG7K5gx2E2a1Q@mail.gmail.com>
Date:	Thu, 26 Feb 2015 23:22:50 +0200
From:	Eyal Birger <eyal.birger@...il.com>
To:	Marcel Holtmann <marcel@...tmann.org>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 1/7] net: bluetooth: compact struct bt_skb_cb by
 inlining struct hci_req_ctrl

Hi Marcel,

On Thu, Feb 26, 2015 at 6:15 PM, Marcel Holtmann <marcel@...tmann.org> wrote:
> Hi Eyal,
>
>> struct hci_req_ctrl is never used outside of struct bt_skb_cb;
>> Inlining it frees 8 bytes on a 64 bit system in skb->cb[] allowing
>> the addition of more ancillary data.
>>
>> Signed-off-by: Eyal Birger <eyal.birger@...il.com>
>> ---
>> include/net/bluetooth/bluetooth.h | 10 +++-------
>> net/bluetooth/hci_core.c          | 12 ++++++------
>> net/bluetooth/hci_event.c         |  4 ++--
>> net/bluetooth/hci_request.c       |  6 +++---
>> net/bluetooth/hci_sock.c          |  2 +-
>> 5 files changed, 15 insertions(+), 19 deletions(-)
>
> it would be a really good idea to actually send this to linux-bluetooth@...r.kernel.org for review.
>

Thanks! I have done that in v2.

Eyal.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html