netdev - Re: [PATCH net-next 4/7] net: packet: use skb->dev as storage for skb orig len instead of skb->cb[]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHsH6GtJauVJULMXpHbrVvQxdm6zdfHKbKvTgJQi2MvdjCrpvQ@mail.gmail.com>
Date:	Thu, 26 Feb 2015 06:03:40 +0200
From:	Eyal Birger <eyal.birger@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	Willem de Bruijn <willemb@...gle.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Shmulik Ladkani <shmulik.ladkani@...il.com>,
	marcel@...tmann.org,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Eyal Birger <eyal.birger@...il.com>
Subject: Re: [PATCH net-next 4/7] net: packet: use skb->dev as storage for skb
 orig len instead of skb->cb[]

>
>         sll->sll_halen = dev_parse_header(skb, sll->sll_addr);
>
> -       PACKET_SKB_CB(skb)->origlen = skb->len;
> +       *PACKET_SKB_ORIGLEN(skb) = skb->len;
>
>         if (pskb_trim(skb, snaplen))
>                 goto drop_n_acct;
>
>         skb_set_owner_r(skb, sk);
> -       skb->dev = NULL;
>         skb_dst_drop(skb);

There is a problem here. skb->dev must still be valid on the call to
skb_set_owner_r().

Sorry about that. I'll spin a second version along with any other
comments raised on this series.

Eyal.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html