netdev - Re: [PATCH net-next 3/7] net: rxrpc: change call to sock_recv_ts_and_drops() on rxrpc recvmsg to sock_recv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1424925652.5565.145.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Wed, 25 Feb 2015 20:40:52 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Eyal Birger <eyal.birger@...il.com>
Cc:	davem@...emloft.net, willemb@...gle.com, edumazet@...gle.com,
	shmulik.ladkani@...il.com, marcel@...tmann.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 3/7] net: rxrpc: change call to
 sock_recv_ts_and_drops() on rxrpc recvmsg to sock_recv_timestamp()

On Thu, 2015-02-26 at 04:10 +0200, Eyal Birger wrote:
> Commit 3b885787ea4112 ("net: Generalize socket rx gap / receive queue overflow cmsg")
> allowed receiving packet dropcount information as a socket level option.
> RXRPC sockets recvmsg function was changed to support this by calling
> sock_recv_ts_and_drops() instead of sock_recv_timestamp().
> 
> However, protocol families wishing to receive dropcount should call
> sock_queue_rcv_skb() or set the dropcount specifically (as done
> in packet_rcv()). This was not done for rxrpc and thus this feature
> never worked on these sockets.
> 
> Formalizing this by not calling sock_recv_ts_and_drops() in rxrpc as
> part of an effort to move skb->dropcount into skb->cb[]
> 
> Signed-off-by: Eyal Birger <eyal.birger@...il.com>
> ---
>  net/rxrpc/ar-recvmsg.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/rxrpc/ar-recvmsg.c b/net/rxrpc/ar-recvmsg.c
> index 4575485..d58ba70 100644
> --- a/net/rxrpc/ar-recvmsg.c
> +++ b/net/rxrpc/ar-recvmsg.c
> @@ -150,7 +150,7 @@ int rxrpc_recvmsg(struct kiocb *iocb, struct socket *sock,
>  				       &call->conn->trans->peer->srx, len);
>  				msg->msg_namelen = len;
>  			}
> -			sock_recv_ts_and_drops(msg, &rx->sk, skb);
> +			sock_recv_timestamp(msg, &rx->sk, skb);
>  		}

I guess this should be the last patch of the serie, as this will
overwrite skb->mark, and rxrpc seems to care about skb->mark 



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html