netdev - Re: [PATCH net-next] usbnet: Fix tx_packets stat for FLAG_MULTI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87lhjj3fha.fsf@nemi.mork.no>
Date:	Fri, 27 Feb 2015 09:50:41 +0100
From:	Bjørn Mork <bjorn@...k.no>
To:	Ben Hutchings <ben.hutchings@...ethink.co.uk>
Cc:	netdev@...r.kernel.org, Oliver Neukum <oliver@...kum.org>,
	ct-linux-kernel <linux-kernel@...ethink.co.uk>,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH net-next] usbnet: Fix tx_packets stat for FLAG_MULTI_FRAME drivers

Ben Hutchings <ben.hutchings@...ethink.co.uk> writes:

> Currently the usbnet core does not update the tx_packets statistic for
> drivers with FLAG_MULTI_PACKET and there is no hook in the TX
> completion path where they could do this.
>
> cdc_ncm and dependent drivers are bumping tx_packets stat on the
> transmit path while asix and sr9800 aren't updating it at all.
>
> Add a packet count in struct skb_data so these drivers can fill it
> in, initialise it to 1 for other drivers, and add the packet count
> to the tx_packets statistic on completion.
>
> Signed-off-by: Ben Hutchings <ben.hutchings@...ethink.co.uk>
> ---
> I have only tested the asix driver after this change; I think cdc_ncm
> and one of the non-multi-packet drivers should also be tested before
> it's applied.

Looks very good to me.  I did a quick test with an MBIM device (the
cdc_mbim driver uses the parts of cdc_ncm you modify here), and it
worked as expected.

Thanks for doing this.  My only complaint was a wishlist for a similar
byte fixup, but then I noticed that you already did that :-)

Tested-by: Bjørn Mork <bjorn@...k.no>



Bjørn
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html