netdev - Re: [PATCH net-next] usbnet: Fix tx_packets stat for FLAG_MULTI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150228.142801.274701022130750604.davem@davemloft.net>
Date:	Sat, 28 Feb 2015 14:28:01 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ben.hutchings@...ethink.co.uk
Cc:	netdev@...r.kernel.org, oliver@...kum.org,
	linux-kernel@...ethink.co.uk, linux-usb@...r.kernel.org
Subject: Re: [PATCH net-next] usbnet: Fix tx_packets stat for
 FLAG_MULTI_FRAME drivers

From: Ben Hutchings <ben.hutchings@...ethink.co.uk>
Date: Thu, 26 Feb 2015 19:34:37 +0000

> Currently the usbnet core does not update the tx_packets statistic for
> drivers with FLAG_MULTI_PACKET and there is no hook in the TX
> completion path where they could do this.
> 
> cdc_ncm and dependent drivers are bumping tx_packets stat on the
> transmit path while asix and sr9800 aren't updating it at all.
> 
> Add a packet count in struct skb_data so these drivers can fill it
> in, initialise it to 1 for other drivers, and add the packet count
> to the tx_packets statistic on completion.
> 
> Signed-off-by: Ben Hutchings <ben.hutchings@...ethink.co.uk>

Applied, thanks Ben.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html