netdev - Re: [PATCH] sh_eth: Fix lost MAC address on kexec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150301.002847.261300841277182822.davem@davemloft.net>
Date:	Sun, 01 Mar 2015 00:28:47 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	geert+renesas@...der.be
Cc:	ben.hutchings@...ethink.co.uk, nobuhiro.iwamatsu.yj@...esas.com,
	horms@...ge.net.au, magnus.damm@...il.com, khilman@...nel.org,
	netdev@...r.kernel.org, linux-sh@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sh_eth: Fix lost MAC address on kexec

From: Geert Uytterhoeven <geert+renesas@...der.be>
Date: Fri, 27 Feb 2015 17:16:26 +0100

> Commit 740c7f31c094703c ("sh_eth: Ensure DMA engines are stopped before
> freeing buffers") added a call to sh_eth_reset() to the
> sh_eth_set_ringparam() and sh_eth_close() paths.
> 
> However, setting the software reset bit(s) in the EDMR register resets
> the MAC Address Registers to zero. Hence after kexec, the new kernel
> doesn't detect a valid MAC address and assigns a random MAC address,
> breaking DHCP.
> 
> Set the MAC address again after the reset in sh_eth_dev_exit() to fix
> this.
> 
> Tested on r8a7740/armadillo (GETHER) and r8a7791/koelsch (FAST_RCAR).
> 
> Fixes: 740c7f31c094703c ("sh_eth: Ensure DMA engines are stopped before freeing buffers")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html