netdev - Re: [PATCH v2 net] net: do not use rcu in rtnl_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150301.002911.1745612209348133533.davem@davemloft.net>
Date:	Sun, 01 Mar 2015 00:29:11 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	nicolas.dichtel@...nd.com, daniel@...earbox.net,
	xiyou.wangcong@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net] net: do not use rcu in rtnl_dump_ifinfo()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 27 Feb 2015 09:42:50 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> We did a failed attempt in the past to only use rcu in rtnl dump
> operations (commit e67f88dd12f6 "net: dont hold rtnl mutex during
> netlink dump callbacks")
> 
> Now that dumps are holding RTNL anyway, there is no need to also
> use rcu locking, as it forbids any scheduling ability, like
> GFP_KERNEL allocations that controlling path should use instead
> of GFP_ATOMIC whenever possible.
> 
> This should fix following splat Cong Wang reported :
 ...
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Fixes: commit 0c7aecd4bde4b7302 ("netns: add rtnl cmd to add and get peer netns ids")
> Cc: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> Reported-by: Cong Wang <xiyou.wangcong@...il.com>
> ---
>  v2: As suggested by Daniel, tweak the changelog to be patchwork compliant ;)

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html