netdev - Re: [PATCH net-next v2] pppoe: Use workqueue to die properly when a PADT is received

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150302.001749.1494675361394874315.davem@davemloft.net>
Date:	Mon, 02 Mar 2015 00:17:49 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	simon@...nz.org.uk
Cc:	netdev@...r.kernel.org, linux-ppp@...r.kernel.org,
	mostrows@...il.com
Subject: Re: [PATCH net-next v2] pppoe: Use workqueue to die properly when
 a PADT is received

From: Simon Farnsworth <simon@...nz.org.uk>
Date: Sun,  1 Mar 2015 10:54:39 +0000

> When a PADT frame is received, the socket may not be in a good state to
> close down the PPP interface. The current implementation handles this by
> simply blocking all further PPP traffic, and hoping that the lack of traffic
> will trigger the user to investigate.
> 
> Use schedule_work to get to a process context from which we clear down the
> PPP interface, in a fashion analogous to hangup on a TTY-based PPP
> interface. This causes pppd to disconnect immediately, and allows tools to
> take immediate corrective action.
> 
> Note that pppd's rp_pppoe.so plugin has code in it to disable the session
> when it disconnects; however, as a consequence of this patch, the session is
> already disabled before rp_pppoe.so is asked to disable the session. The
> result is a harmless error message:
> 
> Failed to disconnect PPPoE socket: 114 Operation already in progress
> 
> This message is safe to ignore, as long as the error is 114 Operation
> already in progress; in that specific case, it means that the PPPoE session
> has already been disabled before pppd tried to disable it.
> 
> Signed-off-by: Simon Farnsworth <simon@...nz.org.uk>
> Tested-by: Dan Williams <dcbw@...hat.com>
> Tested-by: Christoph Schulz <develop@...stov.de>

Applied, thanks Simon.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html