netdev - Re: [PATCH net-next v3 0/7] net: move skb->dropcount to skb->cb[]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150302.002000.2074179681664043670.davem@davemloft.net>
Date:	Mon, 02 Mar 2015 00:20:00 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eyal.birger@...il.com
Cc:	willemb@...gle.com, edumazet@...gle.com, shmulik.ladkani@...il.com,
	linux-bluetooth@...r.kernel.org, marcel@...tmann.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3 0/7] net: move skb->dropcount to skb->cb[]

From: Eyal Birger <eyal.birger@...il.com>
Date: Sun,  1 Mar 2015 14:58:24 +0200

> Commit 977750076d98 ("af_packet: add interframe drop cmsg (v6)")
> unionized skb->mark and skb->dropcount in order to allow recording
> of the socket drop count while maintaining struct sk_buff size.
> 
> skb->dropcount was introduced since there was no available room
> in skb->cb[] in packet sockets. However, its introduction led to
> the inability to export skb->mark to userspace.
> 
> It was considered to alias skb->priority instead of skb->mark.
> However, that would lead to the inabilty to export skb->priority
> to userspace if desired. Such change may also lead to hard-to-find
> issues as skb->priority is assumed to be alias free, and, as noted
> by Shmulik Ladkani, is not 'naturally orthogonal' with other skb
> fields.
> 
> This patch series follows the suggestions made by Eric Dumazet moving
> the dropcount metric to skb->cb[], eliminating this problem
> at the expense of 4 bytes less in skb->cb[] for protocol families
> using it.
> 
> The patch series include compactization of bluetooth and packet
> use of skb->cb[] as well as the infrastructure for placing dropcount
> in skb->cb[].

Ok, I think I can live with this.

Series applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html