netdev - Re: [PATCH net-next 01/14] etherdevice: Add eth_<foo>_addr CONFIG_HAVE_EFFICIENT_UNALIGNED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 03 Mar 2015 11:07:51 -0800
From:	Joe Perches <joe@...ches.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 01/14] etherdevice: Add eth_<foo>_addr
 CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS code

On Tue, 2015-03-03 at 10:42 -0800, Eric Dumazet wrote:
> On Tue, 2015-03-03 at 10:25 -0800, Joe Perches wrote:
> 
> > At least for arm gcc 4.6.3, it emits different code
> > for net/l2tp/l2tp_eth.o
> 
> Then it looks like arm gcc or arm linux memset() should be improved.

Perhaps you can take that up with the gcc folk.

I think it appropriate to improve the actual emitted
code for the compiler I use.

(it seems this code isn't fast-path anywhere though)

> Tracking all memset(x, y, 6) and replace them by some custom version
> seems not very generic to me, when something better can be done.

There's the same argument for the ether_addr_equal and
ether_addr_copy functions.

iow: memcmp, memcpy too

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html