netdev - Re: [PATCH net-next] openvswitch: Fix serialization of non-masked set actions.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150303.155612.1846533641562316910.davem@davemloft.net>
Date:	Tue, 03 Mar 2015 15:56:12 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	joestringer@...ira.com
Cc:	netdev@...r.kernel.org, pshelar@...ira.com,
	linux-kernel@...r.kernel.org, jrajahalme@...ira.com
Subject: Re: [PATCH net-next] openvswitch: Fix serialization of non-masked
 set actions.

From: Joe Stringer <joestringer@...ira.com>
Date: Tue, 3 Mar 2015 12:38:54 -0800

> On 3 March 2015 at 11:39, David Miller <davem@...emloft.net> wrote:
>> From: Joe Stringer <joestringer@...ira.com>
>> Date: Mon,  2 Mar 2015 18:49:56 -0800
>>
>>> Set actions consist of a regular OVS_KEY_ATTR_* attribute nested inside
>>> of a OVS_ACTION_ATTR_SET action attribute. When converting masked actions
>>> back to regular set actions, the inner attribute length was not changed,
>>> ie, double the length being serialized. This patch fixes the bug.
>>>
>>> Fixes: 83d2b9b ("net: openvswitch: Support masked set actions.")
>>> Signed-off-by: Joe Stringer <joestringer@...ira.com>
>>> ---
>>> This fix needs to be applied to net as well; it applies cleanly.
>>
>> This is backwards, don't do this.  Just say that 'net' needs the fix
>> and submit it targetting that tree only.  Things in 'net' propagate
>> into 'net-next' automatically as I do merges over time, but the
>> opposite is not true.
> 
> OK, I'll resend.

If you actually checked the 'net' tree, I applied your patch and even sent
it off to Linus via a pull request 15 minutes ago.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html