netdev - Re: [PATCH net-next] DECnet: Only use neigh_ops for adding the link layer header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20150306.145546.1899132351665683227.davem@davemloft.net>
Date:	Fri, 06 Mar 2015 14:55:46 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ebiederm@...ssion.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] DECnet: Only use neigh_ops for adding the
 link layer header

From: ebiederm@...ssion.com (Eric W. Biederman)
Date: Wed, 04 Mar 2015 10:16:43 -0600

> 
> Other users users of the neighbour table use neigh->output as the method
> to decided when and which link-layer header to place on a packet.
> DECnet has been using neigh->output to decide which DECnet headers to
> place on a packet depending which neighbour the packet is destined for.
> 
> The DECnet usage isn't totally wrong but it can run into problems if the
> neighbour output function is run for a second time as the teql driver
> and the bridge netfilter code can do.
> 
> Therefore to avoid pathologic problems later down the line and make the
> neighbour code easier to understand by refactoring the decnet output
> code to only use a neighbour method to add a link layer header to a
> packet.
> 
> This is done by moving the neigbhour operations lookup from
> dn_to_neigh_output to dn_neigh_output_packet.
> 
> Signed-off-by: "Eric W. Biederman" <ebiederm@...ssion.com>

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html