netdev - Re: [PATCH] bgmac: ratelimit warning messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1425671458.12017.41.camel@perches.com>
Date:	Fri, 06 Mar 2015 11:50:58 -0800
From:	Joe Perches <joe@...ches.com>
To:	Peter Senna Tschudin <peter.senna@...il.com>
Cc:	davem@...emloft.net, hauke@...ke-m.de,
	w-lkml@...enslange-mailadresse.de, zajec5@...il.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bgmac: ratelimit warning messages

On Fri, 2015-03-06 at 19:17 +0100, Peter Senna Tschudin wrote:
> On my test environment the troughput of a file transfer drops from
> 4.4Mbps to 116Kbps due the number of repeated warning messages.
> Adding printk_ratelimit() solves the issue without removing the
> warning message.

What value is there for this message being emitted more than once?

> diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c

> @@ -302,7 +302,7 @@ static int bgmac_dma_rx_skb_for_slot(struct bgmac *bgmac,
>  	slot->skb = skb;
>  	slot->dma_addr = dma_addr;
>  
> -	if (slot->dma_addr & 0xC0000000)
> +	if ((slot->dma_addr & 0xC0000000) && printk_ratelimit())
>  		bgmac_warn(bgmac, "DMA address using 0xC0000000 bit(s), it may need translation trick\n");

Maybe better as a static function

static void check_translate_address(struct bgmac *bgmac, dma_addr_t addr)
{
	static bool printed;

	if (!printed && (addr & (dma_addr_t)0xC0000000)))
		printed = true;
		bgmac_warn(bgmac, etc...);
	}
}

[...]

	check_translate_address(bgmac, slot->dma_addr);

>  	return 0;
> @@ -505,7 +505,7 @@ static int bgmac_dma_alloc(struct bgmac *bgmac)
>  				  ring->mmio_base);
>  			goto err_dma_free;
>  		}
> -		if (ring->dma_base & 0xC0000000)
> +		if ((ring->dma_base & 0xC0000000) && printk_ratelimit())
>  			bgmac_warn(bgmac, "DMA address using 0xC0000000 bit(s), it may need translation trick\n");
>  
>  		ring->unaligned = bgmac_dma_unaligned(bgmac, ring,
> @@ -536,7 +536,7 @@ static int bgmac_dma_alloc(struct bgmac *bgmac)
>  			err = -ENOMEM;
>  			goto err_dma_free;
>  		}
> -		if (ring->dma_base & 0xC0000000)
> +		if ((ring->dma_base & 0xC0000000) && printk_ratelimit())
>  			bgmac_warn(bgmac, "DMA address using 0xC0000000 bit(s), it may need translation trick\n");
>  
>  		ring->unaligned = bgmac_dma_unaligned(bgmac, ring,



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html