netdev - Re: [PATCH] bgmac: ratelimit warning messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACna6rz32WFHNNRLFNDv2E6RBcT_7vFYTOEu66ubvUCQz48udw@mail.gmail.com>
Date:	Sat, 7 Mar 2015 00:27:46 +0100
From:	Rafał Miłecki <zajec5@...il.com>
To:	Peter Senna Tschudin <peter.senna@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	Hauke Mehrtens <hauke@...ke-m.de>,
	w-lkml@...enslange-mailadresse.de, Joe Perches <joe@...ches.com>,
	Network Development <netdev@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] bgmac: ratelimit warning messages

On 6 March 2015 at 19:17, Peter Senna Tschudin <peter.senna@...il.com> wrote:
> On my test environment the troughput of a file transfer drops from
> 4.4Mbps to 116Kbps due the number of repeated warning messages.
> Adding printk_ratelimit() solves the issue without removing the
> warning message.
>
> Signed-off-by: Peter Senna Tschudin <peter.senna@...il.com>
> ---
>  drivers/net/ethernet/broadcom/bgmac.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
> index 676ffe0..d1a259b 100644
> --- a/drivers/net/ethernet/broadcom/bgmac.c
> +++ b/drivers/net/ethernet/broadcom/bgmac.c
> @@ -302,7 +302,7 @@ static int bgmac_dma_rx_skb_for_slot(struct bgmac *bgmac,
>         slot->skb = skb;
>         slot->dma_addr = dma_addr;
>
> -       if (slot->dma_addr & 0xC0000000)
> +       if ((slot->dma_addr & 0xC0000000) && printk_ratelimit())
>                 bgmac_warn(bgmac, "DMA address using 0xC0000000 bit(s), it may need translation trick\n");
>
>         return 0;

Nack. Please just drop this code.

>From what I understand network works for you. I've also checked
Broadcom's open source code, and on SoC we can always safely write
whole low 32b.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html