netdev - netns refcount leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 6 Mar 2015 15:29:49 -0800
From:	Cong Wang <cwang@...pensource.com>
To:	Ying Xue <ying.xue@...driver.com>
Cc:	netdev <netdev@...r.kernel.org>
Subject: netns refcount leak

Hi, Ying


The following commit from you causes a netns refcount leak:

a62fbccecd62bacb4416fc427239f5b43b25d05e is the first bad commit
commit a62fbccecd62bacb4416fc427239f5b43b25d05e
Author: Ying Xue <ying.xue@...driver.com>
Date:   Fri Jan 9 15:27:11 2015 +0800

    tipc: make subscriber server support net namespace

    TIPC establishes one subscriber server which allows users to subscribe
    their interesting name service status. After tipc supports namespace,
    one dedicated tipc stack instance is created for each namespace, and
    each instance can be deemed as one independent TIPC node. As a result,
    subscriber server must be built for each namespace.

    Signed-off-by: Ying Xue <ying.xue@...driver.com>
    Tested-by: Tero Aho <Tero.Aho@...iant.com>
    Reviewed-by: Jon Maloy <jon.maloy@...csson.com>
    Signed-off-by: David S. Miller <davem@...emloft.net>


which prevents a netns being removed if I enable TIPC.

I am not familiar with TIPC code, please take a look.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html