netdev - Re: [PATCH] team: add support to get speed via ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150306.002410.1359006818497057668.davem@davemloft.net>
Date:	Fri, 06 Mar 2015 00:24:10 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	sridhar.samudrala@...el.com
Cc:	jiri@...nulli.us, netdev@...r.kernel.org
Subject: Re: [PATCH] team: add support to get speed via ethtool

From: Sridhar Samudrala <sridhar.samudrala@...el.com>
Date: Thu,  5 Mar 2015 13:48:35 -0800

> +	list_for_each_entry(port, &team->port_list, list) {
> +		if (port->linkup)
> +			speed += port->state.speed;
> +		if (ecmd->duplex == DUPLEX_UNKNOWN &&
> +		    port->state.duplex != 0)
> +			ecmd->duplex = port->state.duplex;

This makes no freakin' sense at all.  Adding the speeds together and
returning that?  Are you kidding me?  Reporting only one of the
duplex settings?  Are you kidding me?

Repeat after me: Speed and duplex has no meaning on software devices

Especially for software devices which aggregate links.

If the user wants the speed in a format that is actually useful, he
has to actually know what the geography of the bond or team slaves,
and since he knows that he can probe the individual hardware devices
for speed and duplex information.

I'm not applying anything like this.

There appears to be some mania afoot about trying to return ethtool
speed/duplex settings on software layering and tunneling device,
can someone please cure this illness before I see more patches like
this one?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html