[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20150306.002725.2246917689017515390.davem@davemloft.net>
Date: Fri, 06 Mar 2015 00:27:25 -0500 (EST)
From: David Miller <davem@...emloft.net>
To: sfeldma@...il.com
Cc: netdev@...r.kernel.org, jiri@...nulli.us,
roopa@...ulusnetworks.com, alexander.h.duyck@...hat.com
Subject: Re: [PATCH net-next v4 0/8] switchdev: add IPv4 routing offload
From: sfeldma@...il.com
Date: Thu, 5 Mar 2015 21:21:12 -0800
> v4:
>
> - Add NETIF_F_NETNS_LOCAL to rocker port feature list to keep rocker
> ports in the default netns. Rocker hardware can't be partitioned
> to support multiple namespaces, currently. It would be interesting
> to add netns support to rocker device by basically adding another
> match field to each table to match on some unique netns ID, with
> a port knowing it's netns ID. Future work TDB.
> - Up-level the RTNH_F_EXTERNAL marking of routes installed to offload
> device from driver to switchdev common code. Now driver can't skip
> routes. Either it can install the route or it cannot. Yes or No.
> If no on any route, all offloading is aborted by removing routes
> from offload device and setting ipv4.fib_offload_disabled so no more
> routes can be offloaded. This is harsh, but it's our starting point.
> We can refine the policies in follow-up work.
> - Add new net.ipv4.fib_offload_disabled bool that is set if anything
> goes wrong with route offloading. We can refine this later to make
> the setting per-device or per-device-port-netdev, but let's start
> here simple and refine in follow-up work.
> - Rebase against Alex's latest FIB changes. I think I did everything
> correctly, and didn't run into any issues with testing, but I'd like
> Alex to look over the changes and maybe follow-up with any cleanups.
Looks great, series applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists