netdev - Re: [PATCH net-next v2 1/1] net: fec: fix receive VLAN CTAG HW acceleration issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150310123045.GB952@pengutronix.de>
Date:	Tue, 10 Mar 2015 13:30:45 +0100
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Michael Grzeschik <mgr@...gutronix.de>
Cc:	Fugang Duan <b38611@...escale.com>, netdev@...r.kernel.org,
	davem@...emloft.net, kernel@...gutronix.de
Subject: Re: [PATCH net-next v2 1/1] net: fec: fix receive VLAN CTAG HW
 acceleration issue

Hello,

On Tue, Mar 10, 2015 at 12:41:02PM +0100, Michael Grzeschik wrote:
> On Tue, Mar 10, 2015 at 07:09:41PM +0800, Fugang Duan wrote:
> > The current driver support receive VLAN CTAG HW acceleration feature
> > (NETIF_F_HW_VLAN_CTAG_RX) through software simulation. There calls the
> > api .skb_copy_to_linear_data_offset() to skip the VLAN tag, but there
> > have overlap between the two memory data point range. The patch just fix
> > the issue.
> > 
> > V2:
> > Michael Grzeschik suggest to use memmove() instead of skb_copy_to_linear_data_offset().
> 
> This probably is not welcome in the patch description.
> 
> How about?
> 
> Cc: <stable@...r.kernel.org> # back to commit 1b7bde6d6
I think the most modern way to do this today is:

	Fixes: 1b7bde6d659d ("net: fec: implement rx_copybreak to improve rx performance")
	Cc: stable@...r.kernel.org

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html