netdev - Re: [PATCH net-next v2 1/1] net: fec: fix receive VLAN CTAG HW acceleration issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150310.124240.1163492906111984968.davem@davemloft.net>
Date:	Tue, 10 Mar 2015 12:42:40 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	mgr@...gutronix.de
Cc:	b38611@...escale.com, netdev@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH net-next v2 1/1] net: fec: fix receive VLAN CTAG HW
 acceleration issue

From: Michael Grzeschik <mgr@...gutronix.de>
Date: Tue, 10 Mar 2015 12:41:02 +0100

> On Tue, Mar 10, 2015 at 07:09:41PM +0800, Fugang Duan wrote:
>> The current driver support receive VLAN CTAG HW acceleration feature
>> (NETIF_F_HW_VLAN_CTAG_RX) through software simulation. There calls the
>> api .skb_copy_to_linear_data_offset() to skip the VLAN tag, but there
>> have overlap between the two memory data point range. The patch just fix
>> the issue.
>> 
>> V2:
>> Michael Grzeschik suggest to use memmove() instead of skb_copy_to_linear_data_offset().
> 
> This probably is not welcome in the patch description.

Why not?  Changelogs aid in understanding how a final commit got to
be the way it was, and it gives credit to people who suggest changes.

> How about?
> 
> Cc: <stable@...r.kernel.org> # back to commit 1b7bde6d6

Nope.

If indeed it is valid for -stable, I handle all networking -stable
submissions by hand rather than via the stable CC: mechanism.
Therefore the patch submitter simply has to ask me to queue the change
up for -stable.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html