netdev - Re: [patch net-next] dsa: change "select" to "depends on" for switchdev in Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGVrzcY9bU+qdYtKj7RBkT0FhhbEUv9oxcTtrYSzqp5PFJWteQ@mail.gmail.com>
Date:	Wed, 11 Mar 2015 09:46:21 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Jiri Pirko <jiri@...nulli.us>
Cc:	netdev <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Scott Feldman <sfeldma@...il.com>,
	Randy Dunlap <rdunlap@...radead.org>,
	Alexei Starovoitov <alexei.starovoitov@...il.com>
Subject: Re: [patch net-next] dsa: change "select" to "depends on" for
 switchdev in Kconfig

2015-03-11 9:44 GMT-07:00 Jiri Pirko <jiri@...nulli.us>:
> This would fix randconfig compile error:
> net/built-in.o: In function `netdev_switch_fib_ipv4_abort':
> (.text+0xf7811): undefined reference to `fib_flush_external'
>
> Also it fixes following warning:
> warning: (NET_DSA) selects NET_SWITCHDEV which has unmet direct dependencies (NET && INET)
>
> Suggested-by: Randy Dunlap <rdunlap@...radead.org>
> Suggested-by: Alexei Starovoitov <alexei.starovoitov@...il.com>
> Signed-off-by: Jiri Pirko <jiri@...nulli.us>

Acked-by: Florian Fainelli <f.fainelli@...il.com>

> ---
>  net/dsa/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/dsa/Kconfig b/net/dsa/Kconfig
> index b45206e..9379a9c 100644
> --- a/net/dsa/Kconfig
> +++ b/net/dsa/Kconfig
> @@ -6,9 +6,8 @@ config HAVE_NET_DSA
>
>  config NET_DSA
>         tristate
> -       depends on HAVE_NET_DSA
> +       depends on HAVE_NET_DSA && NET_SWITCHDEV
>         select PHYLIB
> -       select NET_SWITCHDEV
>
>  if NET_DSA
>
> --
> 1.9.3
>



-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html