netdev - Re: [patch net-next] dsa: change "select" to "depends on" for switchdev in Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 11 Mar 2015 14:53:44 -0700
From:	Randy Dunlap <rdunlap@...radead.org>
To:	Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org
CC:	davem@...emloft.net, f.fainelli@...il.com, sfeldma@...il.com,
	alexei.starovoitov@...il.com
Subject: Re: [patch net-next] dsa: change "select" to "depends on" for switchdev
 in Kconfig

On 03/11/15 09:44, Jiri Pirko wrote:
> This would fix randconfig compile error:
> net/built-in.o: In function `netdev_switch_fib_ipv4_abort':
> (.text+0xf7811): undefined reference to `fib_flush_external'
> 
> Also it fixes following warning:
> warning: (NET_DSA) selects NET_SWITCHDEV which has unmet direct dependencies (NET && INET)
> 
> Suggested-by: Randy Dunlap <rdunlap@...radead.org>

I think that should be Reported-by: /me.

This is probably a good patch but drivers/net/dsa/Kconfig still does several
selects on NET_DSA when NET_SWITCHDEV is not enabled, so there is still a
(different) build error:

warning: (NET_DSA_MV88E6060 && NET_DSA_MV88E6131 && NET_DSA_MV88E6123_61_65 && NET_DSA_MV88E6171 && NET_DSA_MV88E6352 && NET_DSA_BCM_SF2) selects NET_DSA which has unmet direct dependencies (NET && HAVE_NET_DSA && NET_SWITCHDEV)

../net/dsa/slave.c:575:2: error: unknown field 'ndo_switch_parent_id_get' specified in initializer
  .ndo_switch_parent_id_get = dsa_slave_parent_id_get,
  ^
../net/dsa/slave.c:575:2: warning: initialization from incompatible pointer type [enabled by default]
../net/dsa/slave.c:575:2: warning: (near initialization for 'dsa_slave_netdev_ops.ndo_set_config') [enabled by default]
../net/dsa/slave.c:576:2: error: unknown field 'ndo_switch_port_stp_update' specified in initializer
  .ndo_switch_port_stp_update = dsa_slave_stp_update,
  ^
../net/dsa/slave.c:576:2: warning: initialization from incompatible pointer type [enabled by default]
../net/dsa/slave.c:576:2: warning: (near initialization for 'dsa_slave_netdev_ops.ndo_change_mtu') [enabled by default]

> Suggested-by: Alexei Starovoitov <alexei.starovoitov@...il.com>
> Signed-off-by: Jiri Pirko <jiri@...nulli.us>
> ---
>  net/dsa/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/net/dsa/Kconfig b/net/dsa/Kconfig
> index b45206e..9379a9c 100644
> --- a/net/dsa/Kconfig
> +++ b/net/dsa/Kconfig
> @@ -6,9 +6,8 @@ config HAVE_NET_DSA
>  
>  config NET_DSA
>  	tristate
> -	depends on HAVE_NET_DSA
> +	depends on HAVE_NET_DSA && NET_SWITCHDEV
>  	select PHYLIB
> -	select NET_SWITCHDEV
>  
>  if NET_DSA
>  
> 


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html