netdev - Re: [patch net-next] dsa: change "select" to "depends on" for switchdev in Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150311.180459.1988980831203507955.davem@davemloft.net>
Date:	Wed, 11 Mar 2015 18:04:59 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jiri@...nulli.us
Cc:	netdev@...r.kernel.org, f.fainelli@...il.com, sfeldma@...il.com,
	rdunlap@...radead.org, alexei.starovoitov@...il.com
Subject: Re: [patch net-next] dsa: change "select" to "depends on" for
 switchdev in Kconfig

From: Jiri Pirko <jiri@...nulli.us>
Date: Wed, 11 Mar 2015 17:44:28 +0100

> This would fix randconfig compile error:
> net/built-in.o: In function `netdev_switch_fib_ipv4_abort':
> (.text+0xf7811): undefined reference to `fib_flush_external'
> 
> Also it fixes following warning:
> warning: (NET_DSA) selects NET_SWITCHDEV which has unmet direct dependencies (NET && INET)
> 
> Suggested-by: Randy Dunlap <rdunlap@...radead.org>
> Suggested-by: Alexei Starovoitov <alexei.starovoitov@...il.com>
> Signed-off-by: Jiri Pirko <jiri@...nulli.us>

This is a huge mess.

As Randy stated, lots of stuff does select DSA still.

I think all references to switchdev and dsa need to be converted
to depends, in order to really fix this problem properly.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html