netdev - Re: [PATCH net-next 1/8] net: Kill hold_net release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1426093722.11398.51.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Wed, 11 Mar 2015 10:08:42 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	David Miller <davem@...emloft.net>, edumazet@...gle.com,
	netdev@...r.kernel.org, stephen@...workplumber.org,
	nicolas.dichtel@...nd.com, roopa@...ulusnetworks.com,
	hannes@...essinduktion.org, ddutt@...ulusnetworks.com,
	vipin@...ulusnetworks.com, shmulik.ladkani@...il.com,
	dsahern@...il.com, Julian Anastasov <ja@....bg>
Subject: Re: [PATCH net-next 1/8] net: Kill hold_net release_net

On Wed, 2015-03-11 at 10:07 -0700, Eric Dumazet wrote:
> On Wed, 2015-03-11 at 11:35 -0500, Eric W. Biederman wrote:
> 
> > @@ -163,9 +162,7 @@ static void fib_rules_cleanup_ops(struct fib_rules_ops *ops)
> >  static void fib_rules_put_rcu(struct rcu_head *head)
> >  {
> >  	struct fib_rules_ops *ops = container_of(head, struct fib_rules_ops, rcu);
> > -	struct net *net = ops->fro_net;
> >  
> > -	release_net(net);
> >  	kfree(ops);
> >  }
> 
> 
> Looks like this function is no longer needed, can caller can instead do
> 
> -	call_rcu(&rule->rcu, fib_rule_put_rcu);
> +	kfree_rcu(rule, rcu);
> 
> 


Same remark for fib_rule_put_rcu()



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html