netdev - Re: [PATCH net-next 2/5] switchdev: use new swdev ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150315234453.GB16756@penelope.isobedori.kobe.vergenet.net>
Date:	Mon, 16 Mar 2015 08:44:54 +0900
From:	Simon Horman <simon.horman@...ronome.com>
To:	sfeldma@...il.com
Cc:	netdev@...r.kernel.org, jiri@...nulli.us, roopa@...ulusnetworks.com
Subject: Re: [PATCH net-next 2/5] switchdev: use new swdev ops

Hi Scott,

On Sat, Mar 14, 2015 at 11:15:04PM -0700, sfeldma@...il.com wrote:
> From: Scott Feldman <sfeldma@...il.com>
> 
> Move swdev wrappers over to new swdev ops (from previous ndo ops).  No
> functional changes to the implementation.
> 
> Signed-off-by: Scott Feldman <sfeldma@...il.com>

I am a little concerned that this patch will break rocker and dsa until
the 3rd and 4th patches of this series are applied.

Also it is not entirely obvious to me why you check for !ops in
netdev_switch_parent_id_get() and netdev_switch_port_stp_update()
but not in netdev_switch_fib_ipv4_add() and netdev_switch_fib_ipv4_del().

[snip]
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html