[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAE4R7bCfzhmWznFQ_JsUfidCKbuT-rppjXRqpgOcd7uqw1h5FQ@mail.gmail.com>
Date: Sun, 15 Mar 2015 10:56:34 -0700
From: Scott Feldman <sfeldma@...il.com>
To: Jiri Pirko <jiri@...nulli.us>
Cc: Netdev <netdev@...r.kernel.org>,
Roopa Prabhu <roopa@...ulusnetworks.com>
Subject: Re: [PATCH net-next 0/5] switchdev: add swdev ops
On Sun, Mar 15, 2015 at 10:03 AM, Jiri Pirko <jiri@...nulli.us> wrote:
> Sun, Mar 15, 2015 at 07:15:02AM CET, sfeldma@...il.com wrote:
>>From: Scott Feldman <sfeldma@...il.com>
>>
>>Per discussions at netconf, move switchdev ndo ops to a new swdev_ops to
>>keep ndo namespace clean and maintain switchdev-related ops into one place.
>>
>>There are no functional changes here; just shuffling ops around for better
>>organization.
>
> Hmm, I'm not sure this is the right approach. I think we do not need
> only switchdev ops to be pushed out. There are many more ndos that could
> be pushed out as well. What I'm thinking about is some more generic ndo
> struct partitioning. Have to think about the actual implementation some more.
I couldn't see a way to make a more generic ndo struct without casting
args to void * and back, or using a big overlay union. I may be
missing your idea; interested in what you come up with.
In the meantime, can we go with this simple partitioning?
-scott
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists