netdev - Re: [PATCH net-next 0/5] switchdev: add swdev ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150315170355.GJ2043@nanopsycho.orion>
Date:	Sun, 15 Mar 2015 18:03:55 +0100
From:	Jiri Pirko <jiri@...nulli.us>
To:	sfeldma@...il.com
Cc:	netdev@...r.kernel.org, roopa@...ulusnetworks.com
Subject: Re: [PATCH net-next 0/5] switchdev: add swdev ops

Sun, Mar 15, 2015 at 07:15:02AM CET, sfeldma@...il.com wrote:
>From: Scott Feldman <sfeldma@...il.com>
>
>Per discussions at netconf, move switchdev ndo ops to a new swdev_ops to
>keep ndo namespace clean and maintain switchdev-related ops into one place.
>
>There are no functional changes here; just shuffling ops around for better
>organization.

Hmm, I'm not sure this is the right approach. I think we do not need
only switchdev ops to be pushed out. There are many more ndos that could
be pushed out as well. What I'm thinking about is some more generic ndo
struct partitioning. Have to think about the actual implementation some more.

Jiri

>
>Scott Feldman (5):
>  switchdev: add swdev ops
>  switchdev: use new swdev ops
>  rocker: move to new swdev ops
>  dsa: move to new swdev ops
>  netdev: remove ndo ops for switchdev
>
> drivers/net/ethernet/rocker/rocker.c |   64 +++++++++++++++++++---------------
> include/linux/netdevice.h            |   41 ++--------------------
> include/net/switchdev.h              |   38 ++++++++++++++++++++
> net/dsa/slave.c                      |    8 +++--
> net/switchdev/switchdev.c            |   42 +++++++++++-----------
> 5 files changed, 104 insertions(+), 89 deletions(-)
>
>-- 
>1.7.10.4
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html